Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Youtube Player Links #3757

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Fix Youtube Player Links #3757

merged 1 commit into from
Dec 24, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Dec 23, 2024

Task/Issue URL: https://app.asana.com/0/1204099484721401/1208847473290835/f
Tech Design URL:
CC:

Description:
Fixes issue causing taps on Youtube Logo in the player to open multiple tabs, when just one is required.

Steps to test this PR:

  • Set Duck Player mode to “Always”. (Settings > Duck Player > Open Videos in Duck Player)
  • In the same screen, enable “Open Duck Player in a New Tab” if not enabled already
  • Go to youtube.com, find a video and open it, so it opens in Duck Player [Or paste duck://player/tAGnKpE4NCI]
  • Once in Duck Player, tap the Youtube logo in the player (See screenshot)
  • Confirm, a new single tab opens, and the video opens in Youtube.

12-23 at 17 35

@afterxleep afterxleep requested review from a team and quanganhdo and removed request for a team December 23, 2024 16:41
Copy link
Member

@quanganhdo quanganhdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as described.

When "Open Links in Associated Apps" is enabled in Settings and the YouTube logo is tapped, an empty tab is opened and YouTube is launched to open the video. Is this the desired behavior?

@afterxleep afterxleep merged commit 42228ca into main Dec 24, 2024
28 of 29 checks passed
@afterxleep afterxleep deleted the daniel/fix.youtube.links branch December 24, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants