Show VPN onboarding tips #13644
diegoreymendezpr.yml
on: pull_request
Matrix: Test
SwiftLint
38s
Test Shell Scripts
17s
Make Release Build
10m 50s
Verify autoconsent bundle
0s
ShellCheck
7s
Annotations
29 errors and 37 warnings
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Combine/CurrentValuePublisher.swift#L30
Colons should be next to the identifier when specifying a type and next to the key in dictionary literals (colon)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Combine/CurrentValuePublisher.swift#L1
Header comments should be consistent with project patterns (file_header)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Combine/CurrentValuePublisher.swift#L34
Lines should not have trailing whitespace (trailing_whitespace)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Combine/CurrentValuePublisher.swift#L35
Limit vertical whitespace to a single empty line; currently 2 (vertical_whitespace)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TipViews/Model/VPNGeoswitchingTip.swift#L1
Header comments should be consistent with project patterns (file_header)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TipViews/Model/VPNAutoconnectTip.swift#L1
Header comments should be consistent with project patterns (file_header)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TipViews/Model/VPNDomainExclusionsTip.swift#L1
Header comments should be consistent with project patterns (file_header)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TunnelControllerView/TunnelControllerView.swift#L58
Prefer at least one space after slashes for comments (comment_spacing)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TunnelControllerView/TunnelControllerView.swift#L59
Prefer at least one space after slashes for comments (comment_spacing)
|
|
SwiftLint:
LocalPackages/NetworkProtectionMac/Sources/NetworkProtectionUI/Views/TunnelControllerView/TunnelControllerView.swift#L68
Prefer at least one space after slashes for comments (comment_spacing)
|
|
SubscriptionErrorReporterTests.testReporterForFailedToRestoreFromEmailError:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Unit Tests App Store.build/Objects-normal/arm64/SubscriptionErrorReporterTests.d#L1
/Users/runner/work/macos-browser/macos-browser/UnitTests/Subscription/SubscriptionErrorReporterTests.swift:125 - XCTAssertEqual failed: ("["m_mac_store_privacy-pro_app_subscription-purchase_failure_backend_d", "m_mac_daily-os-version-counter", "m_mac_store_privacy-pro_app_subscription-purchase_failure_backend_c"]") is not equal to ("["m_mac_store_privacy-pro_app_subscription-purchase_failure_backend_d", "m_mac_store_privacy-pro_app_subscription-purchase_failure_backend_c"]")
|
|
Test (Sandbox):
UnitTests/Subscription/SubscriptionErrorReporterTests.swift#L125
testReporterForFailedToRestoreFromEmailError, XCTAssertEqual failed: ("["m_mac_store_privacy-pro_app_subscription-purchase_failure_backend_d", "m_mac_daily-os-version-counter", "m_mac_store_privacy-pro_app_subscription-purchase_failure_backend_c"]") is not equal to ("["m_mac_store_privacy-pro_app_subscription-purchase_failure_backend_d", "m_mac_store_privacy-pro_app_subscription-purchase_failure_backend_c"]")
|
|
Test (Sandbox)
Process completed with exit code 1.
|
|
AutoconsentIntegrationTests.testWhenAutoconsentEnabled_cookieConsentManaged:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/AutoconsentIntegrationTests.d#L1
Restarting after unexpected exit, crash, or test timeout in AutoconsentIntegrationTests.testWhenAutoconsentEnabled_cookieConsentManaged(); summary will include totals from previous launches.
|
|
DownloadsIntegrationTests.testWhenDownloadIsStartedInNewTab_tabIsClosed:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/DownloadsIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/DuckDuckGo/Common/Extensions/FutureExtension.swift:27 - failed: caught error: "Timeout"
|
|
DownloadsIntegrationTests.testWhenDownloadIsStartedInNewTabAfterRedirect_tabIsClosed:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/DownloadsIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/DuckDuckGo/Common/Extensions/FutureExtension.swift:27 - failed: caught error: "Timeout"
|
|
DownloadsIntegrationTests.testWhenSaveDialogOpenInBackgroundTabAndTabIsClosed_downloadIsCancelled:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/DownloadsIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/DuckDuckGo/Common/Extensions/FutureExtension.swift:27 - failed: caught error: "Timeout"
|
|
DownloadsIntegrationTests.testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/DownloadsIntegrationTests.d#L1
/Users/runner/work/macos-browser/macos-browser/IntegrationTests/Downloads/DownloadsIntegrationTests.swift:474 - failed - Timeout
|
|
DownloadsIntegrationTests.testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled:
DerivedData/Build/Intermediates.noindex/DuckDuckGo.build/CI/Integration Tests.build/Objects-normal/arm64/DownloadsIntegrationTests.d#L1
Restarting after unexpected exit, crash, or test timeout in DownloadsIntegrationTests.testWhenSaveDialogOpenInBackgroundTabAndWindowIsClosed_downloadIsCancelled(); summary will include totals from previous launches.
|
|
Test (Non-Sandbox)
Restarting after unexpected exit, crash, or test timeout in AutoconsentIntegrationTests.testWhenAutoconsentEnabled_cookieConsentManaged(); summary will include totals from previous launches.
|
|
Test (Non-Sandbox):
DuckDuckGo/Common/Extensions/FutureExtension.swift#L27
testWhenDownloadIsStartedInNewTab_tabIsClosed, failed: caught error: "Timeout"
|
|
Test (Non-Sandbox):
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L228
testWhenDownloadIsStartedInNewTab_tabIsClosed, Failed due to unwaited expectation 'new tab opened'.
|
|
Test (Non-Sandbox):
DuckDuckGo/Common/Extensions/FutureExtension.swift#L27
testWhenDownloadIsStartedInNewTab_tabIsClosed, failed: caught error: "Timeout"
|
|
Test (Non-Sandbox):
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L228
testWhenDownloadIsStartedInNewTab_tabIsClosed, Failed due to unwaited expectation 'new tab opened'.
|
|
Test (Non-Sandbox):
DuckDuckGo/Common/Extensions/FutureExtension.swift#L27
testWhenDownloadIsStartedInNewTab_tabIsClosed, failed: caught error: "Timeout"
|
|
Test (Non-Sandbox):
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L228
testWhenDownloadIsStartedInNewTab_tabIsClosed, Failed due to unwaited expectation 'new tab opened'.
|
|
Test (Non-Sandbox):
DuckDuckGo/Common/Extensions/FutureExtension.swift#L27
testWhenDownloadIsStartedInNewTabAfterRedirect_tabIsClosed, failed: caught error: "Timeout"
|
|
Test (Non-Sandbox):
IntegrationTests/Downloads/DownloadsIntegrationTests.swift#L338
testWhenDownloadIsStartedInNewTabAfterRedirect_tabIsClosed, Failed due to unwaited expectation 'new tab opened'.
|
|
Test (Non-Sandbox):
DuckDuckGo/Common/Extensions/FutureExtension.swift#L27
testWhenDownloadIsStartedInNewTabAfterRedirect_tabIsClosed, failed: caught error: "Timeout"
|
|
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Make Release Build:
DerivedData/Build/Products/Release/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Make Release Build:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test (Sandbox)
No files were found with the provided path: Sandbox-integrationtests-xcodebuild.log. No artifacts will be uploaded.
|
|
Test (Sandbox)
No files were found with the provided path: Sandbox-integrationtests.xcresult. No artifacts will be uploaded.
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Test (Sandbox):
DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Test (Non-Sandbox)
No files were found with the provided path: Non-Sandbox-unittests.xcresult. No artifacts will be uploaded.
|
|
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
|
Test (Non-Sandbox):
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L327
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Artifacts
Produced during runtime
| Name | Size | |
|---|---|---|
|
Non-Sandbox-integrationtests-xcodebuild.log
Expired
|
133 KB |
|
|
Non-Sandbox-integrationtests.xcresult
Expired
|
86.5 MB |
|
|
Non-Sandbox-unittests-xcodebuild.log
Expired
|
854 KB |
|
|
Sandbox-unittests-xcodebuild.log
Expired
|
1.38 MB |
|
|
Sandbox-unittests.xcresult
Expired
|
97 MB |
|