Skip to content
Back to pull request #3490

Validate VPN errors before re-throwing them #13786

Sign in to view logs

Validate VPN errors before re-throwing them

Validate VPN errors before re-throwing them #13786

Triggered via pull request November 3, 2024 23:18
@samsymonssamsymons
synchronize #3490
sam/validate-errors-before-throwing-them-to-the-os
Status Success
Total duration 16m 26s
Billable time 41m
Artifacts –

pr.yml

on: pull_request
Matrix: Test
SwiftLint
41s
SwiftLint
Test Shell Scripts
16s
Test Shell Scripts
Make Release Build
10m 19s
Make Release Build
Verify autoconsent bundle
0s
Verify autoconsent bundle
ShellCheck
7s
ShellCheck
Private API Report  /  Update PR comment
2s
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

35 warnings and 1 notice
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Non-Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L327
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Sandbox)
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel