Skip to content
PR Checks

Try adding true to if statement #13826

Sign in to view logs

Try adding true to if statement

Try adding true to if statement #13826

Triggered via push November 4, 2024 17:12
@THISISDINOSAURTHISISDINOSAUR
pushed 12fdc19
loremattei/pir-integration-tests-for-ci
Status Failure
Total duration 15m 23s
Billable time 39m
Artifacts –

pr.yml

on: push
Matrix: Test
SwiftLint
42s
SwiftLint
Test Shell Scripts
20s
Test Shell Scripts
Make Release Build
10m 26s
Make Release Build
Verify autoconsent bundle
0s
Verify autoconsent bundle
ShellCheck
7s
ShellCheck
Private API Report  /  Update PR comment
4s
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

10 errors, 37 warnings, and 1 notice
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DBPUIViewModel.swift#L43
Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DBPUIViewModel.swift#L44
Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DBPUIViewModel.swift#L45
Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DBPUIViewModel.swift#L46
Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Model/DBPUIViewModel.swift#L47
Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Scheduler/DataBrokerProtectionAgentManager.swift#L182
Prefer at least one space after slashes for comments (comment_spacing)
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Scheduler/DataBrokerProtectionAgentManager.swift#L191
Prefer at least one space after slashes for comments (comment_spacing)
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Scheduler/DataBrokerProtectionAgentManager.swift#L190
A doc comment should be attached to a declaration (orphaned_doc_comment)
SwiftLint: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Services/EmailService.swift#L70
Prefer at least one space after slashes for comments (comment_spacing)
SwiftLint: DBPE2ETests/DBPEndToEndTests.swift#L76
Prefer at least one space after slashes for comments (comment_spacing)
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Authentication/DataBrokerProtectionAuthenticationManaging.swift#L36
expression of type 'Bool' is unused
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Authentication/DataBrokerProtectionAuthenticationManaging.swift#L51
result of call to 'hasValidEntitlement()' is unused
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Authentication/DataBrokerProtectionAuthenticationManaging.swift#L51
code after 'return' will never be executed
Make Release Build: LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Services/EmailService.swift#L73
code after 'return' will never be executed
Make Release Build: DerivedData/Build/Products/Release/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L327
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Non-Sandbox)
Formula postgresql was renamed to postgresql@14.
Test (Non-Sandbox)
Formula postgresql was renamed to postgresql@14.
Test (Sandbox)
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Test (Sandbox)
Formula postgresql was renamed to postgresql@14.
Test (Sandbox)
Formula postgresql was renamed to postgresql@14.
Test (Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Test (Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacTransparentProxyProvider.swift#L77
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Test (Sandbox): main/DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Sandbox): main/DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Sandbox): main/DerivedData/Build/Products/CI/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Test (Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox): main/DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Test (Sandbox)
Skipped Integration_Tests_App_Store.DownloadsIntegrationTests.testWhenLocalFile_downloadStartsAlwaysDisplayingSavePanel