Skip to content

Commit

Permalink
Remove autofill survey (#2819)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1187352151074490/1207364165261200/f
Tech Design URL:
CC:

**Description**:
Remove the autofill survey but not all associated code (e.g. the
persisted flag), since I have zero context there.

**Steps to test this PR**:
1. On main, go to Settings > Passwords and confirm the survey prompt is
visible
2. Do likewise on this branch and confirm it isn't.

<!--
Tagging instructions
If this PR isn't ready to be merged for whatever reason it should be
marked with the `DO NOT MERGE` label (particularly if it's a draft)
If it's pending Product Review/PFR, please add the `Pending Product
Review` label.

If at any point it isn't actively being worked on/ready for
review/otherwise moving forward (besides the above PR/PFR exception)
strongly consider closing it (or not opening it in the first place). If
you decide not to close it, make sure it's labelled to make it clear the
PRs state and comment with more information.
-->

---
###### Internal references:
[Pull Request Review
Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
[Pull Request
Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
  • Loading branch information
THISISDINOSAUR authored May 29, 2024
1 parent 653dcb4 commit 5fc933d
Showing 1 changed file with 0 additions and 36 deletions.
36 changes: 0 additions & 36 deletions DuckDuckGo/Preferences/View/PreferencesAutofillView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -68,42 +68,6 @@ extension Preferences {
// Autofill Content Button
PreferencePaneSection {

// New section
if model.autofillSurveyEnabled {
HStack(alignment: .top, spacing: 20) {
Image(.passwordsDDG128)
.frame(width: 64, height: 48)

VStack(alignment: .leading) {
Text(verbatim: "Help us improve!")
.bold()
Text(verbatim: "We want to make using passwords in DuckDuckGo better.")
.foregroundColor(.greyText)
.padding(.top, 1)

HStack {
Button(action: {
model.disableAutofillSurvey()
}, label: {
Text(verbatim: "No Thanks")
})
Button(action: {
model.launchSurvey()
}, label: {
Text(verbatim: "Take Survey")
})
.buttonStyle(DefaultActionButtonStyle(enabled: true))
}
.padding(.top, 12)
}

Spacer()
}
.padding()
.roundedBorder()
.padding(.bottom, 24)
}

Button(UserText.autofillViewContentButton) {
model.showAutofillPopover()
}
Expand Down

0 comments on commit 5fc933d

Please sign in to comment.