Skip to content

Commit

Permalink
Use improved matching App Store subscription by billing period (#2508)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/0/1206935438989342/f

**Description**:
Improve matching App Store subscription by billing period. Instead of
matching by id pattern we should leverage the enums provided in StoreKit
subscription object.

**Steps to test this PR**:
Smoke test opening the purchase page on Privacy Pro target switched to
use App Store and iOS. Opening purchase page is enough as we fetch the
available subscription and prepare structs to be shown in the purchase
page footer.


---
###### Internal references:
[Pull Request Review
Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f)
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
[Pull Request
Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
  • Loading branch information
miasma13 authored Mar 26, 2024
1 parent e8c8d80 commit 88e3acd
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -14167,7 +14167,7 @@
repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 131.1.0;
version = 131.1.1;
};
};
AA06B6B52672AF8100F541C5 /* XCRemoteSwiftPackageReference "Sparkle" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/BrowserServicesKit",
"state" : {
"revision" : "00d3a6f0040479e1d814a3ae02d1a1dea8225bed",
"version" : "131.1.0"
"revision" : "8b7c87496990b49623e645c25e2198224e9493b2",
"version" : "131.1.1"
}
},
{
Expand Down Expand Up @@ -165,7 +165,7 @@
{
"identity" : "trackerradarkit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/TrackerRadarKit.git",
"location" : "https://github.com/duckduckgo/TrackerRadarKit",
"state" : {
"revision" : "a6b7ba151d9dc6684484f3785293875ec01cc1ff",
"version" : "1.2.2"
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/DataBrokerProtection/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ let package = Package(
targets: ["DataBrokerProtection"])
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "131.1.0"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "131.1.1"),
.package(path: "../PixelKit"),
.package(path: "../SwiftUIExtensions"),
.package(path: "../XPCHelper"),
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/NetworkProtectionMac/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ let package = Package(
.library(name: "NetworkProtectionUI", targets: ["NetworkProtectionUI"]),
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "131.1.0"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "131.1.1"),
.package(path: "../XPCHelper"),
.package(path: "../SwiftUIExtensions"),
.package(path: "../LoginItems"),
Expand Down
2 changes: 1 addition & 1 deletion LocalPackages/SubscriptionUI/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ let package = Package(
targets: ["SubscriptionUI"]),
],
dependencies: [
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "131.1.0"),
.package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "131.1.1"),
.package(path: "../SwiftUIExtensions")
],
targets: [
Expand Down

0 comments on commit 88e3acd

Please sign in to comment.