Manage Private Email Addresses

[afterxleep]

Task/Issue URL: https://app.asana.com/0/72649045549333/1204615490114675/f
BSK PR: duckduckgo/BrowserServicesKit#396

Description:

Steps to test this PR:

Address Management

1. Enable Email protection, if not enabled Already. ( ··· > Email Protection - > Enable Email Protection)
2. Generate a Private Email Address (··· > Email Protection > Generate Private Email Address)
3. Open the Autofill UI, and create a login using the newly created Email address as username
4. 👁️ Observe the new Management UI Shows Up as follows:

5. Hit the "Toggle"
6. 👁️ Observe the address is deactivated, and the UI is updated as follows:

8. Activate the address
9. Create a new login item
10. Enter a non-existent address ending with @duck.com
11. 👁️ Observe the newly created address doesnot show Activate/deactivate controls
12. Close the Autofill management UI
13. Disable Wifi
14. Open the Autofill Management UI and select your valid @duck.com address
15. 👁️ Observe an error appears as follows: (It'll take 5 secons to update due to timeout)

Partial account updating

1. Go to fill.dev email registration
2. Auto-generate a password in the login/signup form

3. 👁️ Open the login management UI and observe a new item was created with the generated password and an empty username
4. Generate a private email from the form

5. 👁️ Observe the previously created item includes both username and password
6. Submit the form
7. 👁️ Observe a "New login saved" popup appears correctly

Partial account updating (Various updates)

1. Go to fill.dev email registration
2. Auto-generate a private email in the login/signup form
3. 👁️ Open the login management UI and observe a new item was created with the generated email and an empty password
4. Generate a password
5. 👁️ Observe the previously created item includes both username and password
6. Generate a new email using the form
7. 👁️ Observe the previously created item includes the updated email
8. Generate a new password
9. 👁️ Observe the previously created item includes the updated password

Credentials save prompt

1. Go to netflix.com
2. Type 'testing123' as the username
3. Type '1234567890' as the password
4. Submit the form
5. 👁️ Observe you get a "Save login?" dialog and it's CTA button says "Save"
6. Hit "Save"
7. 👁️ Observe a new login item was created and username/password are correct

Credentials update prompt

1. Close the browser and reopen
2. Go to fill.dev user registration
3. Type 'testing123' as the username (or the same username you've used in the previous section)
4. Type '0987654321' as the password (or any other password)
5. Submit the form
6. 👁️ Observe you get a "Save login?" dialog, but in this case
7. Hit "Update"
8. 👁️ Observe the login item was updated and username/password are correct

---

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

[amddg44]

@afterxleep generally looking good! There is one flow isn't behaving quite correctly though:

• Visit https://news.ycombinator.com/login
• Enter a password and click login
• Save login when prompted
• Enter a username and click login
• Prompted to save again (not update the login) so ending up with 2 logins

[afterxleep]

I'm not seeing the message "Deactivated and not receiving emails" in the UI as per your screenshot in the test steps - just confirming if this is expected or not? thanks!

@amddg44 These messages have changed like 200 times. I've updated the screenshots with the latest version.

[afterxleep]

@amddg44 I've updated the prompt logic to cover the ycombinator scenario. I was not including empty username accounts as part of the logic. Should be fixed in the BSK via this commit

[amddg44]

LGTM! Really nice work @afterxleep!