Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tds endpoint #1425

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Update tds endpoint #1425

merged 2 commits into from
Aug 3, 2023

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev requested review from a team and jaceklyp and removed request for a team August 2, 2023 18:32
@tomasstrba
Copy link
Contributor

@SlayterDev, could you change the base branch to release/1.50.0? It will be easier to produce the hotfix build

@SlayterDev SlayterDev changed the base branch from develop to release/1.50.0 August 3, 2023 13:36
@tomasstrba tomasstrba requested review from tomasstrba and removed request for jaceklyp August 3, 2023 13:43
@tomasstrba tomasstrba self-assigned this Aug 3, 2023
tomasstrba
tomasstrba approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅
I have verified blocking in https://privacy-test-pages.glitch.me/ and also in websites Steve mentioned in Asana

@SlayterDev SlayterDev merged commit 3c3b34b into release/1.50.0 Aug 3, 2023
10 checks passed
@SlayterDev SlayterDev deleted the brad/tds-endpoint branch August 3, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasstrba tomasstrba tomasstrba approved these changes

Assignees

@tomasstrba tomasstrba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SlayterDev @tomasstrba