Change the way how bookmarks are saved to handle merge errors #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaresiak
force-pushed
the
bartek/tweak-bookmark-saves
branch
from
90500e2
to
e28d043
Compare
Bunn
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
LGTM. Small comment related to an unused self, but I don't really think it's an issue, just raising in case you do :)
Tested:
- Adding/removing/editing bookmarks
- Adding/removing/editing favorites
- Importing from FF
- Opening bookmarks from older version to make sure there's no lost data
- Forcing a bad code path to send a pixel
| let folderFetchRequestResults = try? self.context.fetch(folderFetchRequest) | ||
| do { | ||
| _ = try applyChangesAndSave(changes: { [weak self] context in | ||
| guard let self = self else { |
There was a problem hiding this comment.
Since self is not being used, maybe change it to
guard self != nil else { ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201037661562251/1205176904769815/f
Tech Design URL:
CC:
Description:
Ensure merge errors (caused by other/concurrent context saves) does not cause save failures by reapplying the changes.
Steps to test this PR:
Smoke test Bookmarks feature.
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation