Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable log formatting in notarized build workflow when run with debug logging enabled #1445

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Aug 8, 2023

Task/Issue URL: https://app.asana.com/0/1203301625297703/1205226517596953/f

Description:
Show raw logs when GitHub Actions debug logging is enabled when retrying a workflow.

Steps to test this PR:
Check the workflow run with debug logging enabled. Verify that "Install xcbeautify" didn't run and logs are raw.
Check the regular workflow run. Verify that logs are formatted.


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested a review from jaceklyp August 8, 2023 09:33
Copy link
Contributor

@jaceklyp jaceklyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayoy ayoy merged commit d8386a9 into develop Aug 8, 2023
10 of 13 checks passed
@ayoy ayoy deleted the dominik/gha-debug-logging branch August 8, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants