Subscription refactoring #5 #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…Mock, AppStoreAccountManagementFlowMock
# Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Tab/UserScripts/Subscription/SubscriptionAppStoreRestorer.swift # DuckDuckGo/Tab/UserScripts/Subscription/SubscriptionPagesUserScript.swift # DuckDuckGo/Tab/UserScripts/UserScripts.swift
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…bscription_refactoring_5 # Conflicts: # DuckDuckGo/Tab/UserScripts/Subscription/SubscriptionAppStoreRestorer.swift
…bscription_refactoring_5 # Conflicts: # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Tab/UserScripts/Subscription/SubscriptionAppStoreRestorer.swift # UnitTests/Subscription/SubscriptionAppStoreRestorerTests.swift # UnitTests/Subscription/SubscriptionErrorReporterTests.swift # UnitTests/Subscription/SubscriptionPagesUserScriptTests.swift
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # LocalPackages/DataBrokerProtection/Package.swift # LocalPackages/NetworkProtectionMac/Package.swift # LocalPackages/SubscriptionUI/Package.swift
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Preferences/View/PreferencesRootView.swift # LocalPackages/SubscriptionUI/Sources/SubscriptionUI/SubscriptionAccessView/Model/ShareSubscriptionAccessModel.swift
3 tasks
afterxleep
approved these changes
Jul 4, 2024
| var pixelKit: PixelKit? | ||
|
|
||
| override func setUpWithError() throws { | ||
| // Put setup code here. This method is called before the invocation of each test method in the class. |
| final class SubscriptionErrorReporterTests: XCTestCase { | ||
|
|
||
| override func setUpWithError() throws { | ||
| // Put setup code here. This method is called before the invocation of each test method in the class. |
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jul 5, 2024
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206805455884775/f iOS PR: duckduckgo/iOS#3023 macOS PR: duckduckgo/macos-browser#2930 What kind of version bump will this require?: Major Tech Design URL: https://app.asana.com/0/1205842942115003/1207147511614062/f Dependency injection for many Subscription classes has been improved to allow unit tests. Many test classes have been created and one or more example tests have been implemented to showcase the class testability and mocks Complete tests will be implemented in follow-up tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206805455884775/f
Tech Design URL: https://app.asana.com/0/1205842942115003/1207147511614062/f
CC: @miasma13
Description:
This PR updates BSK from duckduckgo/BrowserServicesKit#874 and contains all the needed refactoring for the Subscription classes inits.
It also contains new unit test classes with example tests:
Complete tests will be implemented in follow-up tasks
Steps to test this PR:
Subscription must work as usual, manual smoke test script available in this README
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation