Improve VPN logging logic #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2024
diegoreymendez
commented
Jul 3, 2024
| @@ -70,7 +69,6 @@ extension OSLog { | |||
| @OSLogWrapper(AppCategories.duckPlayer) static var duckPlayer | |||
| @OSLogWrapper(AppCategories.tabSnapshots) static var tabSnapshots | |||
| @OSLogWrapper(AppCategories.sync) static var sync | |||
| @OSLogWrapper(AppCategories.networkProtection) static var networkProtection | |||
There was a problem hiding this comment.
This isn't really supported so I'm removing it entirely.
samsymons
approved these changes
Jul 5, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jul 5, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207223772590802/f iOS PR: duckduckgo/iOS#3032 macOS PR: duckduckgo/macos-browser#2939 What kind of version bump will this require?: Major/Minor/Patch ## Description Improves the logging logic for the VPN.
|
I'm retargetting to main, since I don't feel comfortable pushing changes to the internal this late. |
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jul 5, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207223772590802/f macOS PR: duckduckgo/macos-browser#2939 BSK PR: duckduckgo/BrowserServicesKit#877 ## Description Improves the logging logic for the VPN.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207223772590802/f
iOS PR: duckduckgo/iOS#3032
BSK PR: duckduckgo/BrowserServicesKit#877
Description
Improves the logging logic for the VPN.
Testing
Test with the App Store build and the Sparkle build.
~/Desktop/netp.logand~/Desktop/netpAppStore.logmake sense.Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation