Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sync error pixels #2946

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Update Sync error pixels #2946

merged 5 commits into from
Jul 5, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Jul 5, 2024

Task/Issue URL: https://app.asana.com/0/1201621708115095/1207559244852258/f

Description:
Rename count limit exceeded as object limit exceeded and add "Too Many Requests" pixels.

Steps to test this PR:
Since this change doesn't modify any logic related to processing errors, it's enough that you verify that pixel names are correct. The simplest is to add this snippet of code at the bottom of AppDelegate's applicationDidFinishLaunching:

PixelKit.fire(GeneralPixel.syncBookmarksObjectLimitExceededDaily, frequency: .legacyDaily)
PixelKit.fire(GeneralPixel.syncCredentialsObjectLimitExceededDaily, frequency: .legacyDaily)
PixelKit.fire(GeneralPixel.syncBookmarksRequestSizeLimitExceededDaily, frequency: .legacyDaily)
PixelKit.fire(GeneralPixel.syncCredentialsRequestSizeLimitExceededDaily, frequency: .legacyDaily)
PixelKit.fire(GeneralPixel.syncBookmarksTooManyRequestsDaily, frequency: .legacyDaily)
PixelKit.fire(GeneralPixel.syncCredentialsTooManyRequestsDaily, frequency: .legacyDaily)
PixelKit.fire(GeneralPixel.syncSettingsTooManyRequestsDaily, frequency: .legacyDaily)

Then run the app and check the log. Compare output with what's expected in the Asana task.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Collaborator

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ayoy ayoy merged commit 1a52bd5 into main Jul 5, 2024
20 checks passed
@ayoy ayoy deleted the dominik/sync-pixels-update branch July 5, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants