Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIR Database Migrations to Address Integrity Issues & Related Feature Flagger #2997

Merged
merged 17 commits into from
Jul 25, 2024
Merged

PIR Database Migrations to Address Integrity Issues & Related Feature Flagger #2997

merged 17 commits into from
Jul 25, 2024

Commits on Jul 23, 2024

  1. Extract Migrations to dedicated type, add initial v3 migration cleanu… 

    …p, add tests and test data
    @aataraxiaa
    aataraxiaa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f7219c4 View commit details
    Browse the repository at this point in the history

  2. Implement correct passing test, cleanup Swiftlint

    @aataraxiaa
    aataraxiaa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    faba82d View commit details
    Browse the repository at this point in the history

  3. Add explicit foreign key cleanup as a precaution after orphan cleanup… 

    …, update test
    @aataraxiaa
    aataraxiaa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    44e7db2 View commit details
    Browse the repository at this point in the history

  4. Ensure all table data is deleted when clearing profile data

    @aataraxiaa
    aataraxiaa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3e8a5a9 View commit details
    Browse the repository at this point in the history

  5. Re-create tables with cascading deletes and add some testing

    @aataraxiaa
    aataraxiaa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b0e07fb View commit details
    Browse the repository at this point in the history

  6. Rerun orphan cleanup as last migration step, add documentation, impro… 

    …ve tests
    @aataraxiaa
    aataraxiaa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8d6bc3b View commit details
    Browse the repository at this point in the history

  7. Add test to check migration of very invalid database data

    @aataraxiaa
    aataraxiaa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8caac04 View commit details
    Browse the repository at this point in the history

  8. Add specific migration failed integrity error and propagate to pixel

    @aataraxiaa
    aataraxiaa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    42af11d View commit details
    Browse the repository at this point in the history

  9. Add feature flag and temp local BSK reference

    @aataraxiaa
    aataraxiaa committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    9a0bf61 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Implement PIR Migrations feature flagger & tests. Refactor migrations… 

    … & vault creation for testability. Add tests & mocks. Remove some previous changes.
    @aataraxiaa
    aataraxiaa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    f0a8e90 View commit details
    Browse the repository at this point in the history

  2. Correctly name file

    @aataraxiaa
    aataraxiaa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    2a498f3 View commit details
    Browse the repository at this point in the history

  3. Repeat DB integrity issues test and add documentation. Enable feature… 

    … flag for all.
    @aataraxiaa
    aataraxiaa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d374d4a View commit details
    Browse the repository at this point in the history

  4. Temporarily disable test due to bypassed feature flag

    @aataraxiaa
    aataraxiaa committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    dbbbdfa View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. PR feedback changes and improvements

    @aataraxiaa
    aataraxiaa committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    9cb5635 View commit details
    Browse the repository at this point in the history

  2. Implement temporary date range check to allow migrations for internal… 

    … users
    @aataraxiaa
    aataraxiaa committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8a0d316 View commit details
    Browse the repository at this point in the history

  3. Fix comment

    @aataraxiaa
    aataraxiaa committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f0b76ed View commit details
    Browse the repository at this point in the history

  4. PR feedback

    @aataraxiaa
    aataraxiaa committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    495608f View commit details
    Browse the repository at this point in the history