Sort bookmarks in bookmarks panel #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotaemepereira
force-pushed
the
juan/sort-bookmarks-in-panel
branch
from
eef7f23
to
3f1583e
Compare
ayoy
reviewed
Jul 23, 2024
ayoy
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Great job @jotaemepereira! Sorting works great and the code is nice and clean. Just please update string comparison to use localized case insensitive compare and it's good to go. Thanks!
jotaemepereira
force-pushed
the
juan/sort-bookmarks-in-panel
branch
from
6e93c79
to
9133780
Compare
jotaemepereira
force-pushed
the
feature/search-and-sort-bookmarks-panel
branch
from
a4b209c
to
832d72d
Compare
samsymons
approved these changes
Jul 24, 2024
jotaemepereira
force-pushed
the
feature/search-and-sort-bookmarks-panel
branch
from
832d72d
to
b79737f
Compare
TODO: Add unit tests
jotaemepereira
force-pushed
the
juan/sort-bookmarks-in-panel
branch
from
d240c73
to
fc01a2f
Compare
jotaemepereira
merged commit c82227f
into
feature/search-and-sort-bookmarks-panel
20 checks passed
jotaemepereira
added a commit
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204006570077678/1207680520620398/f
Tech Design URL:
CC:
Description
Acceptance criteria
AC1
Given a user that opens the bookmarks panel
When the user taps on the sort icon without any saved sort option
Then a menu with the following options appears Manual (selected), Name (unselected), Ascending (disabled) and Descending (disabled)
And sort icon is the ascending one
AC2
Given a user that taps the sort button
When the user taps on the name option
Then the tree view is ordered by title ascending
And the Ascending (selected by default) and Descending options are available.
AC3
Given a user that taps the sort button
When the user taps on the Descending option
Then the tree view is ordered by title descending
And the sort icon changes to descending
AC4
Given a user that taps the sort button
When the user taps on the Manual option
Then the tree view is ordered by proximity to the root
AC5
Given a user in the bookmarks panel
When the user starts a search
Then the list of results should respect the selected sorting order
AC6
Given a user that restarted the browser
When the user goes to the bookmarks panel
Then the last selected sorting option should be remembered
And the tree view should be sorted by the last remembered
Demo
sort-demo.mov
Steps to test this PR
Definition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation