Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sync E2E tests crashing #3002

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Fix Sync E2E tests crashing #3002

merged 1 commit into from
Jul 22, 2024

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Jul 21, 2024

Task/Issue URL: https://app.asana.com/0/1199230911884351/1207860806206145/f

Description:
This change fixes UpdateController usage so that it's not references in UI tests runs.

Steps to test this PR:
Verify that this Sync E2E UI Tests run and this UI tests run are green.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy requested review from Bunn and tomasstrba July 21, 2024 21:17
Copy link
Contributor

@tomasstrba tomasstrba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some problems with 'Find in Page' tests but it probably isn't related

@ayoy ayoy merged commit 0a259e9 into main Jul 22, 2024
33 checks passed
@ayoy ayoy deleted the dominik/fix-ui-tests branch July 22, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants