fix index out-of-bounds in startAttachingCrashLogMessages #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 The Asana task linked in the PR description is not added to macOS App Board project.
|
github-actions
bot
added
bot: not in app board
Bunn
approved these changes
Jul 23, 2024
6 tasks
mallexxx
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jul 23, 2024
Bunn
removed
the
bot: not in app board
mallexxx
added a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414709148257752/1207877553454228/f
BSK PR: duckduckgo/BrowserServicesKit#906
Description:
Fixes Out-of-bounds exception when no records in crashDiagnostics array
Steps to test this PR:
Simulate a crash in App Store target with debugger detached
Set a breakpoint at CrashCollection.swift:122 and remove items from crashDiagnostics array (using LLDB: po crashDiagnostics.removeAll())
validate the code is not crashing when adding a record to the array
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation