Add search and sort observability metrics

[jotaemepereira]

Task/Issue URL: https://app.asana.com/0/1199230911884351/1207704569751027/f
Tech Design URL:
CC:

Description

Adds pixels to observe interactions with search and sort.

Steps to test this PR

Sort button clicked

1. Open the bookmarks panel
2. Press the sort button to see the list of options of sort options.
3. A pixel called sort_bookmarks_button_clicked should be fired

Sort button dismissed

1. Open the bookmarks panel
2. Press the sort button to see the list of options of sort options.
3. Then, do not select any option from the menu
4. A pixel called sort_bookmarks_button_dismissed should be fired.

Sort mode by name

1. Open the bookmarks panel
2. Press the sort button to see the list of options of sort options.
3. Then select the Name option. Repeat from 2, and select Ascending and Descending
4. A pixel called sort_bookmarks_by_name should be fired.

Search executed

1. Open the bookmarks panel
2. Press the search button
3. Start a search
4. A pixel called search_bookmarks_executed should be fired. This pixel is fired daily.

Search result clicked

1. Open the bookmarks panel
2. Press the search button
3. Start a search
4. Tap a bookmark or folder on the search results
5. A pixel called search_result_clicked should be fired when the bookmark an folder are tapped.

Definition of Done

• Does this PR satisfy our Definition of Done?

—

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

[THISISDINOSAUR]

Awesome, really glad to see how thoroughly tested this is!

[THISISDINOSAUR]

Just have one comment, but otherwise testing looks good

[THISISDINOSAUR]

What's the motivation behind this versus using PixelKit directly?
In general I'd say we use PixelKit directly, and I'd rather keep things consistent unless there's a good reason for it

[jotaemepereira]

I prefer to encapsulate this kind of logic; if you have multiple fires to the same pixel and need to change something (for example, the frequency), you have only one place to do it.

Finding the pixels related to a specific feature is easier. Now, you need to navigate through the large pixel list in the GeneralPixel enum.

Do you think it’s a blocker for this PR?

[THISISDINOSAUR]

Nah it's not a blocker. I think your reasoning makes sense, but I would rather do it or not do it universally, and think the consistency is more valuable than the benefits of either approach.