Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DuckPlayer overlay bug #3348

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Fix DuckPlayer overlay bug #3348

merged 2 commits into from
Sep 27, 2024

Conversation

Bunn
Copy link
Collaborator

@Bunn Bunn commented Sep 26, 2024

Task/Issue URL: https://app.asana.com/0/1204167627774280/1208392875411872
Tech Design URL:
CC:

Description:
Fix overlay issue when clicking on watch on youtube

Steps to test this PR:

  1. Set duck player to always ask
  2. Open a youtube video
  3. Watch on Duck Player
  4. Click on "Watch on youtube" from the overlay
  5. Check if the youtube video plays without the overlay

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@Bunn Bunn marked this pull request as ready for review September 27, 2024 12:27
Copy link
Contributor

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM

  • Please file a task to remove DP singleton (for later)
  • Please file a task for the Back Navigation Bug from Youtube
  • Also please add a task to follow up with some DuckPlayer TabExtension tests so we can start covering for these breakages.

@Bunn Bunn merged commit 9eb1eae into main Sep 27, 2024
33 of 35 checks passed
@Bunn Bunn deleted the bunn/duckplayer/fix-overlay-bug branch September 27, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants