Fix passwords empty screen lock icon in dark mode #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
commented
Oct 22, 2024
| @@ -1159,3 +1130,17 @@ extension PasswordManagementViewController: NSMenuItemValidation { | |||
| return !accounts.isEmpty | |||
| } | |||
| } | |||
|
|
|||
| struct PasswordManagementEmptyStateMessage: View { | |||
There was a problem hiding this comment.
In-line links + images are just so much easier with SwiftUI...
amddg44
reviewed
Oct 23, 2024
| hostingView.autoresizingMask = [.height, .width] | ||
| hostingView.translatesAutoresizingMaskIntoConstraints = true | ||
| emptyStateMessageContainer.addSubview(hostingView) | ||
| emptyStateMessageHeight.constant = listModel.emptyStateMessageViewHeight |
There was a problem hiding this comment.
I think the height constant is causing some issues with other languages which have longer strings
amddg44
approved these changes
Oct 23, 2024
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203822806345703/1208570651540471/f
Description:
The lock icon on passwords screen empty state has wrong dark mode colour.
This fixes it so it's the same colour as the text.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation