Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send success pixel on successful data import #3437

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

graeme
Copy link
Collaborator

@graeme graeme commented Oct 22, 2024

Task/Issue URL: https://app.asana.com/0/1203822806345703/1207768516988587/f

Description:

During ✓ Postmortem: Deduplicate passwords on import it was mentioned that having insight on the rate of import success vs failure would be useful.

We already have Pixels for failures but cannot calculate a success rate from that alone.

This adds import success Pixels with source and make sure the failure Pixels and their source parameter are being sent properly.

Steps to test this PR:

  1. Run this with the debugger attached
  2. Perform password / bookmark / favicon imports from all the import sources (or at least a sensible subset)
  3. Check that, on successful import, the pixel: m_mac_data-import-succeeded_{action}_{source} is sent

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@graeme graeme requested a review from amddg44 October 22, 2024 13:58
Copy link
Contributor

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out a whole bunch of imports and LGTM!

One small note, from the list of action cases bookmarks, passwords, favicons, generic I wasn’t able to trigger any bookmarks or passwords actions even when selecting import via html / csv file but perhaps I missed an import flow
image

Copy link

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants