Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide continue setup cards after 1 week #3471

Merged
merged 23 commits into from
Nov 20, 2024
Merged

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1202406491309510/1208589738926535/f

Description:

  1. Fixed Xcode previews
  2. Always show X button on the Next Step cards
  3. Clear X button background to match designs
  4. Dismiss Next Steps cards after 1 week

Steps to test this PR:

  1. ./clean-app.sh debug
  2. Validate X button is always visible on the Next Step cards
  3. Move system date 1 week forward, validate the cards are hidden

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested a review from ayoy October 29, 2024 11:41
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪 thanks @mallexxx!

Copy link
Contributor

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Nov 14, 2024
@github-actions github-actions bot removed the stale label Nov 15, 2024
@mallexxx mallexxx merged commit 7202ff2 into main Nov 20, 2024
20 checks passed
@mallexxx mallexxx deleted the alex/hide-continue-setup-cards branch November 20, 2024 12:58
samsymons added a commit that referenced this pull request Nov 21, 2024
…g-error

# By Anka (5) and others
# Via GitHub (5) and Dominik Kapusta (1)
* main: (28 commits)
  Add attemptCount and maxAttempts to broker config (#3533)
  Hide continue setup cards after 1 week (#3471)
  Add expectation when checking email text field value (#3572)
  [macos] adding support for message bridge (#3558)
  Update PIR test runner (#3570)
  Add support for controlling sections visibility on HTML New Tab Page (#3551)
  Bump version to 1.115.0 (311)
  macOS 13/14 UI test compilation fix (#3569)
  macOS 13/14 UI test compilation fix (#3569)
  Fix bug where bookmarks bar prompt does not hide bar (#3553)
  Add OS version to download fail pixel (#3568)
  Remove get_tasks_in_last_internal_release (#3566)
  Bump version to 1.115.0 (310)
  Update skip-release check
  Update fastlane plugin to 0.11.6
  Bump ddg-apple-automation version for bugfix (#3565)
  PIR E2E tests GitHub actions (#3528)
  Update autoconsent to v11.5.0 (#3561)
  Bump version to 1.115.0 (309)
  Set marketing version to 1.115.0
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants