Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freemium PIR: Ship Review Changes - Updated New Tab Banner UI #3501

Open
wants to merge 3 commits into
base: release/1.113.0
Choose a base branch
from

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented Nov 4, 2024

Task/Issue URL: https://app.asana.com/0/1206488453854252/1208677018043704/f

Description: Updates the Freemium PIR new tab page promotion banner as follows:

  1. Changes the icon
  2. Adds a title
  3. Changes the description text and color
  4. Adds optional bold text to the promotion description text

Note: Targeting release branch as I want these changes to be available publicly next week

Test Prerequisites

  1. Set yourself as an internal user via Debug menu → Set Internal User State
  2. Disable/Signout of Privacy Pro via Settings menu → PP → Remove from this device
  3. Select Debug menu → Freemium -> Reset all Freemium State
  4. Select Debug menu → Freemium -> Enroll into Experiment

Steps to test this PR:

  1. Relaunch the browser
  2. Ensure you see the promotion on the new tab page and that it appears as below:
Screenshot 2024-11-04 at 17 59 10

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@aataraxiaa aataraxiaa requested a review from ayoy November 4, 2024 18:06
@aataraxiaa aataraxiaa marked this pull request as ready for review November 4, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant