Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIR end to end tests: This PR exists just to test action triggers #3511

Closed
wants to merge 164 commits into from
Closed

PIR end to end tests: This PR exists just to test action triggers #3511

wants to merge 164 commits into from
+1,302 −187

Conversation

THISISDINOSAUR
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR commented Nov 5, 2024 •
edited
Loading

Task/Issue URL:
Tech Design URL:
CC:

Description:

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:
1.

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

aataraxiaa and others added 30 commits June 20, 2024 18:17
@aataraxiaa
PoC Integration Test for Scan Start
1c1e530
@aataraxiaa
Iterate on Scan Start Integration Test
ff4f60e
@aataraxiaa
Try Keychain CI Setup
12fb9f4
@aataraxiaa
Iterate on file storage instead of keychain, update tests
fa8d651
@THISISDINOSAUR
Merge branch 'pete/poc-pir-integration-tests' into elle/pir-integrati…
041e8ba 
…on-tests-for-ci-development

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Storage/DataBrokerProtectionSecureVault.swift
@THISISDINOSAUR
Make broker updater use fake brokers when running integration tests
b6e6f69
@THISISDINOSAUR
Fix BrokerUpdater import
ceec0b9
@THISISDINOSAUR
Add AppKitExtensions to test targets
d5fa35b
@THISISDINOSAUR
Add static fake broker json file
0ff1d03
@THISISDINOSAUR
Add initial integration tests
c1ececa
@THISISDINOSAUR
Add AppKitExtensions to integration tests app store
8517acd
@THISISDINOSAUR
Remove superfluous tests
c7a1c5f
@THISISDINOSAUR
Comment out possibly failing part of test
f244633
@THISISDINOSAUR
Revert changes to DataBrokerProtectionSecureVault
4b924b8
@THISISDINOSAUR
Revert "Comment out possibly failing part of test"
470db96 
This reverts commit f244633.
@THISISDINOSAUR
Revert keyStoreProvider
9529ed6
@THISISDINOSAUR
Restore original sandbox test tool version`
067c7c1
@ayoy
Merge branch 'main' into elle/pir-integration-tests-for-ci-development
79945b5
@THISISDINOSAUR
Add new fake broker config
e354a38
@THISISDINOSAUR
Remove old fake brokers
2e33028
@THISISDINOSAUR
Make scheduler run even more frequently
e01be8d
@THISISDINOSAUR
Update integration tests to work with the new fake broker
8b695b0
@THISISDINOSAUR
Try adding fake broker setup to CI
e1161bf
@THISISDINOSAUR
Merge branch 'main' into elle/pir-integration-tests-for-ci-development
51eb4bb 
# Conflicts:
#	.github/workflows/pr.yml
#	DuckDuckGo.xcodeproj/project.pbxproj
#	LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Operations/DataBrokerProtectionBrokerUpdater.swift
@THISISDINOSAUR
Fix indentation
fe0c8b0
@THISISDINOSAUR
Add set up docker build step
d43db95
@loremattei
Swith to running fake broker locally
446035b
@loremattei
Disable matrix for testing
981bb8e
@loremattei
Checkout fake broker repository
fb8979b
@loremattei
Give GHA access to the repo
49becde
@THISISDINOSAUR
Comment out most if lines
4f44724
@THISISDINOSAUR
Fix syntax error
3a82d0d
@THISISDINOSAUR
Fix additional syntax error
ca9d65f
@THISISDINOSAUR
Try exact name again
1edb59d
@THISISDINOSAUR
Fix syntax error
3b798f2
@THISISDINOSAUR
Try full ref
3b9dc27
@THISISDINOSAUR
Try switchiing to github.event
8b41857
@THISISDINOSAUR
Go back to ref name
4933be5
@THISISDINOSAUR
Remove refs/heads
fc036e1
@THISISDINOSAUR
Try something that really should work no matter what
1c248aa
@THISISDINOSAUR
...except this time spell it right
0d4bfcf
@THISISDINOSAUR
Try inverting contains in case the docs are wrong
2344356
@THISISDINOSAUR
Add thing to help debug
0408556
@THISISDINOSAUR
Let's see if the name is null
87790a9
@THISISDINOSAUR
Rename action
6328206
@THISISDINOSAUR
Try yet something else
ab3d83a
@THISISDINOSAUR
Try changing to more specific check
921f36f
@THISISDINOSAUR
Change contains to startWith
46a4707
@THISISDINOSAUR
Readd file checks
bbbc887
@THISISDINOSAUR
Add check to make sure it runs on schedule
acd6ddb
@THISISDINOSAUR
Change branch checks to use base not head
1bfc67b
@THISISDINOSAUR
Add file just to make dif
db6f8b2
@THISISDINOSAUR
Add file for test purposes
b1d99c6
@THISISDINOSAUR
Remove test files
3f3fb98
@THISISDINOSAUR
Add check to run tests from PR description
fa57902
@THISISDINOSAUR
Add file to create diff
db22344
@THISISDINOSAUR
Fix PR template checkbox
6f02bbe
@THISISDINOSAUR
Make random change to test triggers
d73e4f9
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Fails
🚫 Please, don't forget to add a link to the internal task
🚫 No configuration is allowed inside Xcode project file - use xcconfig files instead.
Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against d73e4f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@THISISDINOSAUR @aataraxiaa @ayoy @loremattei