Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIR E2E tests #3512

Draft
wants to merge 177 commits into
base: main
Choose a base branch
from
Draft

PIR E2E tests #3512

wants to merge 177 commits into from
+1,064 −158

Conversation

THISISDINOSAUR
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR commented Nov 5, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1208692061054859/f
Tech Design URL:
CC:

Description:
Adds PIR e2e tests, along with associated code changes to enable them. The yml file for the GitHub Action however has been separated out into a separate PR

Steps to test this PR:

  1. In bit warden, you can get a token that will allow you to run the tests locally. It's called "Privacy pro staging token for PIR end to end tests"
  2. If you set this as a temp environmental variable locally called PRIVACYPRO_STAGING_TOKEN, the tests should then work.
  3. You will also need to setup the fake broker locally, which has instructions here: https://github.com/duckduckgo/pir-fake-broker
  4. Run the DBPEndToEndTests file and check that it passes

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

aataraxiaa and others added 30 commits June 20, 2024 18:17
@aataraxiaa
PoC Integration Test for Scan Start
1c1e530
@aataraxiaa
Iterate on Scan Start Integration Test
ff4f60e
@aataraxiaa
Try Keychain CI Setup
12fb9f4
@aataraxiaa
Iterate on file storage instead of keychain, update tests
fa8d651
@THISISDINOSAUR
Merge branch 'pete/poc-pir-integration-tests' into elle/pir-integrati…
041e8ba 
…on-tests-for-ci-development

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Storage/DataBrokerProtectionSecureVault.swift
@THISISDINOSAUR
Make broker updater use fake brokers when running integration tests
b6e6f69
@THISISDINOSAUR
Fix BrokerUpdater import
ceec0b9
@THISISDINOSAUR
Add AppKitExtensions to test targets
d5fa35b
@THISISDINOSAUR
Add static fake broker json file
0ff1d03
@THISISDINOSAUR
Add initial integration tests
c1ececa
@THISISDINOSAUR
Add AppKitExtensions to integration tests app store
8517acd
@THISISDINOSAUR
Remove superfluous tests
c7a1c5f
@THISISDINOSAUR
Comment out possibly failing part of test
f244633
@THISISDINOSAUR
Revert changes to DataBrokerProtectionSecureVault
4b924b8
@THISISDINOSAUR
Revert "Comment out possibly failing part of test"
470db96 
This reverts commit f244633.
@THISISDINOSAUR
Revert keyStoreProvider
9529ed6
@THISISDINOSAUR
Restore original sandbox test tool version`
067c7c1
@ayoy
Merge branch 'main' into elle/pir-integration-tests-for-ci-development
79945b5
@THISISDINOSAUR
Add new fake broker config
e354a38
@THISISDINOSAUR
Remove old fake brokers
2e33028
@THISISDINOSAUR
Make scheduler run even more frequently
e01be8d
@THISISDINOSAUR
Update integration tests to work with the new fake broker
8b695b0
@THISISDINOSAUR
Try adding fake broker setup to CI
e1161bf
@THISISDINOSAUR
Merge branch 'main' into elle/pir-integration-tests-for-ci-development
51eb4bb 
# Conflicts:
#	.github/workflows/pr.yml
#	DuckDuckGo.xcodeproj/project.pbxproj
#	LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Operations/DataBrokerProtectionBrokerUpdater.swift
@THISISDINOSAUR
Fix indentation
fe0c8b0
@THISISDINOSAUR
Add set up docker build step
d43db95
@loremattei
Swith to running fake broker locally
446035b
@loremattei
Disable matrix for testing
981bb8e
@loremattei
Checkout fake broker repository
fb8979b
@loremattei
Give GHA access to the repo
49becde
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 79956e5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@THISISDINOSAUR @aataraxiaa @ayoy @loremattei