Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Android ppro messaging part 1 #118

Merged
merged 6 commits into from
Dec 3, 2024

Conversation

karlenDimla
Copy link
Contributor

Specs: https://app.asana.com/0/1207619243206445/1208299529724942/f
Target enable date: Dec 2, 2024

@karlenDimla karlenDimla requested a review from a team as a code owner November 27, 2024 11:18
Copy link

@karlenDimla karlenDimla force-pushed the feature/karl/android-ppro-messaging-p1 branch from 315ab8e to 029602a Compare November 27, 2024 12:16
@karlenDimla karlenDimla force-pushed the feature/karl/android-ppro-messaging-p1 branch from 029602a to 3ce6446 Compare November 28, 2024 08:22
@@ -59,6 +59,9 @@
},
"matchingRules": [
12
],
"exclusionRules": [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excluding message if already interacted with previous or current ones.

@@ -405,7 +417,29 @@
{
"id": 12,
"targetPercentile": {
"before": 0.05
"before": 0.0625
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 messages should have now 6.25%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the first one to be 5% as we are updating the taarget to 10% (https://app.asana.com/0/0/1208299529724942/1208890135916138/f)

{
"id": 13,
"targetPercentile": {
"before": 0.0666
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of how we process messages (in order and first match wins), to keep the same probability in all 4 variants, we should calculate percentile based on the message position. For example: percentile of message B to be 6.25% should consider probability of message A not showing.

@cmonfortep
Copy link
Collaborator

@karlenDimla do we need to put any minVersion supported here?

@cmonfortep cmonfortep force-pushed the feature/karl/android-ppro-messaging-p1 branch from bc6a54e to 303dad9 Compare November 28, 2024 15:11
@nalcalag nalcalag self-assigned this Dec 2, 2024
@karlenDimla karlenDimla force-pushed the feature/karl/android-ppro-messaging-p1 branch from 303dad9 to 649a9cd Compare December 2, 2024 16:44
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@karlenDimla karlenDimla force-pushed the feature/karl/android-ppro-messaging-p1 branch from c6e01fa to 469c370 Compare December 3, 2024 12:58
@karlenDimla karlenDimla force-pushed the feature/karl/android-ppro-messaging-p1 branch from 469c370 to 382e8ea Compare December 3, 2024 13:00
Copy link
Collaborator

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@karlenDimla karlenDimla merged commit 438c3d1 into main Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants