-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Android ppro messaging part 1 #118
Conversation
Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/android-config.json |
315ab8e
to
029602a
Compare
029602a
to
3ce6446
Compare
@@ -59,6 +59,9 @@ | |||
}, | |||
"matchingRules": [ | |||
12 | |||
], | |||
"exclusionRules": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excluding message if already interacted with previous or current ones.
@@ -405,7 +417,29 @@ | |||
{ | |||
"id": 12, | |||
"targetPercentile": { | |||
"before": 0.05 | |||
"before": 0.0625 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 messages should have now 6.25%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating the first one to be 5% as we are updating the taarget to 10% (https://app.asana.com/0/0/1208299529724942/1208890135916138/f)
{ | ||
"id": 13, | ||
"targetPercentile": { | ||
"before": 0.0666 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of how we process messages (in order and first match wins), to keep the same probability in all 4 variants, we should calculate percentile based on the message position. For example: percentile of message B to be 6.25% should consider probability of message A not showing.
@karlenDimla do we need to put any minVersion supported here? |
…d with previous or current ones.
bc6a54e
to
303dad9
Compare
303dad9
to
649a9cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
c6e01fa
to
469c370
Compare
469c370
to
382e8ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Specs: https://app.asana.com/0/1207619243206445/1208299529724942/f
Target enable date: Dec 2, 2024