Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds quarterly Dec 2024 survey #132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cmonfortep
Copy link
Collaborator

Asana: https://app.asana.com/0/1207619243206445/1209004061290230/f

Description: See https://app.asana.com/0/1207619243206445/1209004032626933/f

Testing:

  • Validate Survey is shown and params are added

@cmonfortep cmonfortep requested a review from a team as a code owner December 23, 2024 14:43
@cmonfortep cmonfortep changed the title adds quarterly Dec 2024 survey Adds quarterly Dec 2024 survey Dec 23, 2024
Copy link

Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmonfortep I added a couple of comments. Could you confirm the exclusionRules and the placeholder added? The Asana task mentions Announce, so I assume it refers to the speaker icon.

live/android-config/android-config.json Show resolved Hide resolved
live/android-config/android-config.json Outdated Show resolved Hide resolved
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants