Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS Privacy Pro subscriber survey #58

Merged
merged 13 commits into from
Jun 17, 2024
Merged

iOS Privacy Pro subscriber survey #58

merged 13 commits into from
Jun 17, 2024

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented May 3, 2024 •
edited
Loading

Background:

Task: https://app.asana.com/0/1200848785558646/1207585156849487/f

This PR adds a Privacy Pro subscriber survey, for users with 14+ days of activity.

How to test:

  1. Update the iOS app to use the staging URL below
  2. Now we need a Privacy Pro account with the right attributes - this can be difficult as you can't easily fake the account's age, so instead just sign into any Privacy Pro account and modify the values passed to UserAttributeMatcher in RemoteMessaging.swift

In this case, you want an account that is subscribed for at least 14 days, and was purchased via Apple. In my case I only have a Stripe account, so I manually edited UserAttributeMatcher to take an apple purchase platform. If you want to test this with a legit account, contact Michal.

Screenshot attached of this message with my real Privacy Pro account, but with the purchase platform overridden:

Simulator Screenshot - iPhone 15 Pro - 2024-06-16 at 20 05 23

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/pre/ios-config.json

@samsymons samsymons mentioned this pull request May 6, 2024
Merged
10 tasks
samsymons added 4 commits May 20, 2024 19:49
@samsymons
Merge branch 'main' into sam/remote-messaging-privacy-pro-updates
3ce37ae 
# By amddg44 (2) and others
# Via GitHub
* main:
  Remove iOS may 2024 email campaign (#61)
  iOS email campaign (May 2024) (#60)
  iOS: Disable May suvey (#59)
  Add voice search promo (#56)

# Conflicts:
#	live/ios-config/ios-config.json
@samsymons
Update RMF manifest.
b55e795
@samsymons
Use Privacy Pro attributes.
3a4868a
@samsymons
Replace survey URL.
aed9a85
@samsymons samsymons mentioned this pull request May 21, 2024
Merged
8 tasks
samsymons added 3 commits May 26, 2024 12:32
@samsymons
Merge branch 'main' into sam/remote-messaging-privacy-pro-updates
7d5ee15 
# By Cristian Monforte
# Via GitHub
* main:
  remove incident messages (#64)
  Message users about incident (#63)

# Conflicts:
#	live/ios-config/ios-config.json
@samsymons
Add PrivacyPro placeholder.
aa55595
@samsymons
Add new attributes.
2eccecc
@samsymons samsymons mentioned this pull request Jun 1, 2024
Merged
10 tasks
@samsymons samsymons mentioned this pull request Jun 6, 2024
Merged
13 tasks
samsymons added 4 commits June 6, 2024 05:53
@samsymons
Rename PrivacyPro to PrivacyShield.
01d4139
@samsymons
Add new attributes.
545cda8
@samsymons
Remove da attribute which is no longer supported.
27449c8
@samsymons
Merge branch 'main' into sam/remote-messaging-privacy-pro-updates
82c1757 
# By Cristian Monforte (2) and Sam Symons (1)
# Via GitHub
* main:
  Release winner message PPro - AppTP - June (#67)
  iOS survey June 2024 (#66)
  PPro Promo June (#65)

# Conflicts:
#	live/ios-config/ios-config.json
@samsymons samsymons changed the title [Do Not Merge] iOS remote message Privacy Pro test iOS Privacy Pro subscriber survey Jun 17, 2024
amddg44
amddg44 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@amddg44 amddg44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have an active account that is 52 days old and is an apple purchase and everything worked exactly as expected. The message looks good in light & dark mode and the survey URL built correctly 🚀

@samsymons samsymons merged commit 929df69 into main Jun 17, 2024
2 checks passed
@samsymons samsymons mentioned this pull request Jun 20, 2024
Merged
@samsymons samsymons deleted the sam/remote-messaging-privacy-pro-updates branch June 30, 2024 02:45
@samsymons samsymons mentioned this pull request Aug 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amddg44 amddg44 amddg44 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsymons @amddg44