Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy pro Onboarding promo June #68

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

cmonfortep
Copy link
Collaborator

@cmonfortep cmonfortep commented Jun 12, 2024

Asana: https://app.asana.com/0/0/1207546055898908/f

Test:

  • Check requirements in https://app.asana.com/0/0/1207546055898908/f
  • Use staging endpoint (you can enable it in internal RMF settings)
  • Ensure copies are correct (validate config)
  • Ensure URLs are correct (validate config)
  • For testing, you will need to hardcode some values in the codebase (e.g: ppro eligible to return true, days since installed 3)
  • Ensure a user will see at least 1 message but only 1 (if you interact with one, you won't see another)

Copy link

@nalcalag
Copy link
Contributor

@cmonfortep not sure how targetPercentile works in the new RMF, but in the old surveys framework you just needed to add the percentile per variant which here would be 0.25 each.
In that case, because all messages share matchingRules, could we just create 1 and assign to all of them?

@cmonfortep
Copy link
Collaborator Author

Posted in Asana, but also posting here. Since the goal is to have 25% chances to see one of the 4 messages, and they share target audience, we need a different value on each percentile. Using the same percentile will give more probability to appear to the first one, since we evaluate in order.

# Conflicts:
#	live/android-config/android-config.json
@cmonfortep cmonfortep requested a review from nalcalag June 19, 2024 17:31
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the percentile explanation. LGTM!

@cmonfortep cmonfortep merged commit dfbe2dc into main Jun 20, 2024
1 check passed
samsymons added a commit that referenced this pull request Jun 20, 2024
Task: https://app.asana.com/0/0/1207624570799167/f

This PR restores the iOS Privacy Pro survey, which was accidentally removed in #68.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants