Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Launch ppro exit survey #81

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Android: Launch ppro exit survey #81

merged 1 commit into from
Jul 8, 2024

Conversation

karlenDimla
Copy link
Contributor

@karlenDimla karlenDimla requested a review from a team as a code owner July 4, 2024 11:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Your PR is hosted at https://staticcdn.duckduckgo.com/remotemessaging/config/staging/android-config.json

@karlenDimla karlenDimla force-pushed the origin/karl/android-ppro-exit-survey branch from 1c33644 to 5adfb8a Compare July 4, 2024 12:03
@karlenDimla karlenDimla force-pushed the origin/karl/android-ppro-exit-survey branch from 5adfb8a to 8818f74 Compare July 4, 2024 12:04
@karlenDimla
Copy link
Contributor Author

Tested the following (on 5.207.2) and works as expected:

  • No subscription -> no survey
  • Active subscription -> See new subscriber survey
  • Expiring subscription -> See exit survey
  • Expired subscription -> See exit survey
  • Interacted with exit survey + Active subscription -> No survey

cmonfortep
cmonfortep approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karlenDimla karlenDimla merged commit 3667ef0 into main Jul 8, 2024
1 check passed
@karlenDimla karlenDimla deleted the origin/karl/android-ppro-exit-survey branch July 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonfortep cmonfortep cmonfortep approved these changes

Assignees

@cmonfortep cmonfortep

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karlenDimla @cmonfortep