Duniverse v1.13 #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ocamlmklib` supports some but not all linker flags. we have some `LDFLAGS` that are not supported by `ocamlmklib`, so they need to be passed via `-ldopt`. this PR prepends `-ldopt` to each word in `LIBS` (which is set to `LDFLAGS` in ./configure).
Add functions to generate integers pseudo-randomly
Add fast path when extraction leads to intnat
pass LDFLAGS to ocamlmklib via -ldopt
…es added by configure
It looks like `-native` causes `ocamldep` to produce insufficient dependencies for a bytecode + native build like we need to do. See log at https://881129.bugs.gentoo.org/attachment.cgi?id=832035
The build uses ocamlc to compile C files, so it's more reliable to test C compilation and linking using $ocamlc than using $cc. Also: add .gitattributes for Windows Co-authored-by: Xavier Leroy <[email protected]>
With the flambda variants of the ocaml compiler, compilation failed with `Error (warning 58 [no-cmx-file]): no cmx file was found in path for module Zarith_version, and its interface was not compiled with -opaque`
When testing for the availability of a library, don't pass compilation flags to the linker: they are not relevant and flexdll may not recognize them. Co-authored-by: Hugo Heuzard <[email protected]>
We no longer need it to select between assembly files.
This works better on Mac with Homebrew, for example. Fall back to the old method if pkg-config is not available or doesn't work.
Namely: - Whether GMP was found from pkg-config - Which C includes were selected (in summary of configuration)
Some simplifications and improvements to the configure script
Co-authored-by: Hugo Heuzard <[email protected]> Co-authored-by: Xavier Leroy <[email protected]>
This patch improves the bounds used in of_float to decide whether the double can fit into an OCaml 63-bit tagged int. The upper bound is 0x3ffffffffffffe00, which is exactly representable as a double (2^53-1)*2^9 = (2-2^-52) * 2^61 as it is 1.1...1 * 2^61 with 52 ones after the 1, and is less than 2^62, so it is representable as an OCaml int. The double just after 0x3ffffffffffffe00 is 0x4000000000000000, or 2^62, which does not fit an OCaml int. For the lower bound, -0x4000000000000000 is exactly representable as a double, but also the smallest number that fits an OCaml int.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zarithv1.13config.guesswhich was removed from Zarith upstream.duniverse-v1.13as well, but I don't think I can set that.