Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings streamline #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Docstrings streamline #52

wants to merge 2 commits into from

Conversation

philippWassibauer
Copy link
Contributor

effort to get SDK documentation into docs.dune.com

bh2smith
bh2smith reviewed May 28, 2024
View reviewed changes
Copy link
Collaborator

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the tests are only failing because timestamps were changed again. This should be adjusted to pass before approval/merge.

@philippWassibauer
Copy link
Contributor Author

I want to add to it a bit still and then I will merge.

@bh2smith
Copy link
Collaborator

bh2smith commented Jun 4, 2024

Once you rebase on main the test errors have already been fixed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bh2smith bh2smith bh2smith left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippWassibauer @bh2smith