Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping react versions, fixing some tests, adding some documentation #60

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gurnro
Copy link

@gurnro gurnro commented Jan 3, 2024

Bumped node modules to get working with latest react and node 18.
Updated docs to make a little clearer how the tests work
Added an update snapshot script, added this to readme to make sure its clearer.
Fixed jest polyfills for node 18

Code builds fine but no local server included for tests to run against any local url in order for the fragment tests to run.

Thanks!

@dunglas
Copy link
Owner

dunglas commented Jan 3, 2024

Thanks! We'll review this after #55 is merged.

@gurnro
Copy link
Author

gurnro commented Jan 6, 2024

Fixed some ordering issues with the jest polyfills and fixed prettier issues, moved to use pipeable stream - tests that I can run are passing.
If you could add a mock server to the project at _custom that would really help, I assume its just something missing in the library.
Thanks

Rowan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants