Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Token / Jottacloud follow up #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

albertony
Copy link
Contributor

@albertony albertony commented Jun 23, 2022

Follow up from #7:

  1. First commit adds support for v2 authid with cli tokens, which was simply skipped in Added support for Jottacloud cli token #7.
  2. Second commit disables v2 authid for providers that uses refresh token rotation, since these are not (currently) compatible, if my understanding is correct! This is related to Disable automatic use of v2 authid for Jottacloud duplicati#4779 which prevents "auto-upgrade" from v1 to v2 authid in Jottacloud backend of Duplicati. The current change in oauth handler would also do the same, but also prevents explicit use of v2 authids, and is a more "consistent" solution. For more background, see Disable automatic use of v2 authid for Jottacloud duplicati#4779.
  3. Third commit corrects (hopefully) the "fetch token" handling when using cli token, enabling automatic insert of the authid back into duplicati. (This fetch token thing was something I had a question about in the original pr, but never got an answer).

@albertony albertony marked this pull request as draft June 23, 2022 11:49
@albertony albertony marked this pull request as ready for review June 23, 2022 14:11
@albertony albertony changed the title Added support for v2 tokens with Jottacloud Handling authid v2 with cli tokens Jun 23, 2022
@albertony albertony marked this pull request as draft June 23, 2022 15:35
@albertony albertony marked this pull request as ready for review June 23, 2022 15:42
@albertony albertony changed the title Handling authid v2 with cli tokens CLI Token / Jottacloud follow up Jun 23, 2022
@jthall
Copy link

jthall commented Sep 24, 2022

@albertony this now deployed at https://duplicati-oauth-handler-beta.appspot.com/

@albertony
Copy link
Contributor Author

@kenkendk Any chance of getting this considered...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants