Convert all ArrayObjects to native arrays [Trying to solve broken down migrations] #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
Migration resets/rollbacks don't seem to work with this library, the suspect parts in Larvel are
Migrator->rollback
andMigrator->runDown
As you can see,
rollback
casts each migration to an object before passing torunDown
, which then tries to access the object property. As php-rql returnsArrayObject
's, this access fails.This change is a bit hacky but converts
ArrayObjects
to native arrays!Questions:
Any idea whyArrayObject
is used? (I have an issue open with php-rql)Is there a better approach?Thanks!