Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add built-in ReST support #16

Open
wants to merge 2 commits into
base: leapide-code-1.58.2
Choose a base branch
from
Open

Add built-in ReST support #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dff211b
Install ReST support from prebuilt extensions
randomir May 2, 2022
a5ea7dd
Adapt ReST extension settings for optimal UX
randomir May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions-prebuilt
Open in desktop
Submodule extensions-prebuilt updated from 1928ec to 401fbe
28 changes: 27 additions & 1 deletion extensions/gitpod/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,32 @@ export async function activate(context: vscode.ExtensionContext) {
const gitpodApi = workspaceInfoResponse.getGitpodApi()!;
const workspaceContextUrl = vscode.Uri.parse(workspaceInfoResponse.getWorkspaceContextUrl());

//#region LeapIDE config update
(async () => {
// update `name` to `value` in "User settings" if user didn't explicitly set/modify it
function updateIfDefault(config: vscode.WorkspaceConfiguration, name: string, value: any) {
if (config.get(name) === config.inspect(name)?.defaultValue) {
config.update(name, value, vscode.ConfigurationTarget.Global);
}
}
let config = vscode.workspace.getConfiguration();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can use const (optional)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, config.update call did not work when config was declared as const. I'll double-check.


// NOTE: The following ReST settings assume `[email protected]`.
// Some are deprecated in the latest version (currently that's v187).

// ReST lang server makes the editor too slow, it's not worth it. Also this prevents "install snooty/esbonio" notification
updateIfDefault(config, 'restructuredtext.languageServer.disabled', true);

// ReST linter is too slow: each linting call is a blocking shell exec (to rstcheck, doc8, etc)
updateIfDefault(config, 'restructuredtext.linter.disabled', true);

// Use 'docutils' for ReST live preview (sphinx is an overkill just for rendering readme).
// The weird empty string setting comes from https://docs.restructuredtext.net/articles/configuration.html#conf-py-path.
// This also prevents prompting user to select between sphinx (conf.py location) and docutils
updateIfDefault(config, 'restructuredtext.confPath', '');
})();
//#endregion

//#region server connection
const factory = new JsonRpcProxyFactory<GitpodServer>();
type UsedGitpodFunction = ['getWorkspace', 'openPort', 'stopWorkspace', 'setWorkspaceTimeout', 'getWorkspaceTimeout', 'getLoggedInUser', 'takeSnapshot', 'controlAdmission', 'sendHeartBeat'];
Expand Down Expand Up @@ -655,7 +681,7 @@ export async function activate(context: vscode.ExtensionContext) {
viewColumn: vscode.ViewColumn.Beside,
preserveFocus: true,
kioskMode: true,
title: "Problem Inspector"
title: 'Problem Inspector'
});
}
context.subscriptions.push(gitpodWorkspaceTreeDataProvider.onDidExposeServedPort(port => {
Expand Down