Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add ability to set adapter scoped metadata #46

Merged
merged 3 commits into from
Jul 21, 2023
Merged

feat: Add ability to set adapter scoped metadata #46

merged 3 commits into from
Jul 21, 2023

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Jul 20, 2023

Partially addresses #40

We need a generic way to set the adapter specific metadata like we do in Rust.

@bhelx bhelx marked this pull request as ready for review July 20, 2023 17:34
nilslice
nilslice approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bhelx bhelx merged commit 170be9b into main Jul 21, 2023
2 checks passed
@bhelx bhelx deleted the datadog-set-metadata-go branch July 21, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice nilslice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhelx @nilslice