fix: memory allocation events should only be sent attached to function calls #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhelx
reviewed
Jul 24, 2023
Comment on lines
-107
to
-109
| if let Err(e) = self.collector.try_send(ev) { | ||
| error!("error recording memory allocation: {}", e); | ||
| } |
There was a problem hiding this comment.
Hmm yeah, this seems like it might have been leftover from the refactor. Let me test it tomorrow to make sure.
bhelx
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the allocation should only ever be recorded as part of a function call event, not standlone. In the case prior to this commit, we actually collect the allocation as part of the function call (e.g.
sbrk) and also on its own, sent the allocation event along.