refactor(incentives): skip epoch distribution to perpetual gauges #1655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mtsitrin
commented
Dec 15, 2024
mtsitrin
commented
- custom created gagues are non-perpetual
- perpetual gauges not iterated on epoch end
keruch
approved these changes
Dec 16, 2024
| // } | ||
| // get active, non-perpetual gauges | ||
| // perpetual gauges are paid directly by the protocol (i.e streamer) | ||
| newGauges := make([]types.Gauge, 0, len(gauges)) |
There was a problem hiding this comment.
super nit: i guess most of the gauges will be perpetual, so maybe it's worth doing make([]types.Gauge, 0) to avoid runtime overhead. otherwise runtime will try to find a memory slice for len(gauges) though in fact we need much less.
|
still relevant? |
yes, not for 3d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.