-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance _get_and_store_range
Function to Include Trip Statistics and Last API Call Tracking
#993
base: master
Are you sure you want to change the base?
Conversation
Now I only have one concern: the current iteration does not use UUID in the docs_cursor = edb.get_timeseries_db().find({
"metadata.key": "stats/server_api_time",
"user_id" : user_id
}) Thoughts? |
@JGreenlee Comments addressed, I split the function into a different file as suggested -- though it may be overkill. Seeking thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good refactor! I agree that the smaller functions are overkill.
Sometimes it's just a matter of finding the balance between tidiness and complexity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good
@JGreenlee Comments addressed |
Addressed comments, reduced overkill on refactor Forgot to add last_call_ts
e4e8ed9
to
8faafe1
Compare
@JGreenlee Addressed and rebased |
Overview
Enhances
_get_and_store_range
by addingtotal_trips
,labeled_trips
, andlast_call
fields to the user profile, enabling better insights into user activities and API usage.Changes
Extended User Profile Updates:
total_trips
: Total number of trips recorded for the user.labeled_trips
: Number of labeled/annotated trips.Integrated Last API Call Tracking:
stats/server_api_time
to retrieve timestamps of the lastGET
andPUT
API calls.last_call
in the user's profile in UNIX format.Testing
Please review and provide feedback or approval.