Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign Build Deployment Process (External) #125
Redesign Build Deployment Process (External) #125
Changes from 19 commits
6aed57a
8b0317f
7d3cd86
355db20
3c17d18
e402a61
ffcdbc8
d6a6809
102899a
50a7b63
db85f75
2dab7a1
43f3d5a
89ed59a
37c7599
e962d13
8d2464d
d49a275
efaf216
baac678
629b3a1
fee9437
9622279
6e3f2be
1745634
21ca992
58093d3
368900b
bf3e9f7
6eebf87
e760598
9444e60
40beb80
29ebf49
1d0a937
308eca0
35e09cb
d919a34
11cdafb
1dda106
66bd0a6
426ae50
3b298fc
4335f39
b330f96
9b1dca5
ab0e157
7c78c18
27c2f42
c8b6dca
40bf355
803e9c2
7ee8e61
af3c2d3
91d5251
d3bf89f
c58b5dd
14775b5
f595b0d
2f17e5d
25dcba1
82cf4e9
5d7f6d8
cedf7b1
6849f84
f325eb3
eb4672c
e87058d
7483f2a
2434648
29353b0
b98cf53
8153155
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this script launched from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that you should also remove the
WEB_SERVER_HOST
variable in this file since it is unused.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file does use this variable in setting the PYTHONPATH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WEB_SERVER_HOST
is always set to0.0.0.0
. we can just hardcode ithttps://github.com/search?q=repo%3Ae-mission%2Fem-public-dashboard%20WEB_SERVER_HOST&type=code
e-mission/e-mission-server#961 (comment)
e-mission/e-mission-server@f65f94c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, future fix: this can be removed and simplified (similar to e-mission/e-mission-server#961 (comment))