Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file-preview-card-group): add class for card description #2465

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

LuLaValva
Copy link
Member

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Add a class for the descriptions of file-preview-card within file-preview-card-group

Screenshots

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Oct 9, 2024

⚠️ No Changeset found

Latest commit: 36a3988

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@LuLaValva LuLaValva self-assigned this Oct 10, 2024
@LuLaValva
Copy link
Member Author

After some discussion offline, I ended up doing kind of a major refactor of the way that file-preview-card is organized. The names that changed were taken from the design side, but I'm not super happy with a few of them and would be happy to change. Please take a look.

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. A couple of minor comments.

The rest (naming convention) we'll discuss "offline."

var(--color-background-primary)
);
border-radius: 1em;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this spec-ed in ems? Seems like we should be using a token.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really just needs to be any number larger than the height so edges will be rounded, I used em since that will work even if a chrome extension or something changes font size to be larger.

dist/file-preview-card/file-preview-card.css Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants