Add internal builtin topics as DdsTopic(s) [20039] #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Lopez Fernandez <[email protected]>
juanlofer-eprosima
temporarily deployed
to
codecov
GitHub Actions
Inactive
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #97 +/- ##
==========================================
- Coverage 20.03% 19.64% -0.40%
==========================================
Files 29 29
Lines 2700 2698 -2
Branches 1412 1412
==========================================
- Hits 541 530 -11
- Misses 1704 1721 +17
+ Partials 455 447 -8 ☔ View full report in Codecov by Sentry. |
juanlofer-eprosima
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #87 introduced a regression in which internal builtin topics were added as
DistributedTopicinstead ofDdsTopic. As a consequence, these were not well processed when an allowlist was being provided (casting toDdsTopicfailed).