Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21407] Remove example #101

Merged
merged 5 commits into from
Jul 23, 2024
Merged

[21407] Remove example #101

merged 5 commits into from
Jul 23, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jul 22, 2024 •
edited
Loading

Description

This PR removes the discovery-server.xsd (because not used) and the example (because there is already one in Fast DDS)

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The added tests pass locally.
  • N/A Changes are backwards compatible.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf
Compile examples
e884747 
Signed-off-by: elianalf <[email protected]>
@elianalf
Fix compilation error
088e254 
Signed-off-by: elianalf <[email protected]>
@elianalf elianalf added this to the v2.0.0 milestone Jul 22, 2024
JesusPoderoso
JesusPoderoso suggested changes Jul 22, 2024
View reviewed changes
.github/workflows/config/build.meta Outdated Show resolved Hide resolved
resources/xsd/discovery-server.xsd Outdated Show resolved Hide resolved
@elianalf elianalf mentioned this pull request Jul 22, 2024
Closed
7 tasks
@JesusPoderoso JesusPoderoso self-requested a review July 22, 2024 10:20
JesusPoderoso

This comment was marked as outdated.

Sign in to view

@elianalf elianalf changed the title Hotfix: build example Remove example Jul 22, 2024
JesusPoderoso
JesusPoderoso suggested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing also this section and this usage from the main CMakeLists.txt

@elianalf
Apply suggestions
68d980e 
Signed-off-by: elianalf <[email protected]>
@elianalf elianalf changed the title Remove example [21407] Remove example Jul 22, 2024
@JesusPoderoso JesusPoderoso requested review from JesusPoderoso and removed request for JesusPoderoso July 23, 2024 09:58
JesusPoderoso
JesusPoderoso approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@elianalf elianalf requested review from JesusPoderoso and removed request for JesusPoderoso July 23, 2024 11:05
@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 23, 2024
@JesusPoderoso JesusPoderoso merged commit 3271a62 into master Jul 23, 2024
7 of 10 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/build_example branch July 23, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso Awaiting requested review from JesusPoderoso

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@elianalf @JesusPoderoso