-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21230] Migrate Discovery Server CI to Github (backport #90) #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of c323886 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
5 tasks
JesusPoderoso
force-pushed
the
mergify/bp/1.2.x/pr-90
branch
from
July 1, 2024 15:13
4c4824f
to
046a8cf
Compare
JesusPoderoso
force-pushed
the
mergify/bp/1.2.x/pr-90
branch
from
July 1, 2024 15:14
046a8cf
to
bf75778
Compare
JesusPoderoso
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
July 1, 2024 15:14
JesusPoderoso
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
* Refs #21230: Migrate Discovery Server CI to Github Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Add RELEASE_SUPPORT.md file Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Add missing flaxy test arg Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Introduce improvements from similar PR reviews Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Apply rev suggestions Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Add missing CI checks in PR template Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> (cherry picked from commit c323886)
JesusPoderoso
force-pushed
the
mergify/bp/1.2.x/pr-90
branch
from
July 2, 2024 08:54
bf75778
to
61ae162
Compare
JesusPoderoso
approved these changes
Jul 2, 2024
JesusPoderoso
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
labels
Jul 2, 2024
JesusPoderoso
added a commit
that referenced
this pull request
Jul 24, 2024
* Refs #21230: Migrate Discovery Server CI to Github Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Add RELEASE_SUPPORT.md file Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Add missing flaxy test arg Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Introduce improvements from similar PR reviews Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Apply rev suggestions Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Add missing CI checks in PR template Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> (cherry picked from commit c323886) Co-authored-by: Jesús Poderoso <[email protected]>
JesusPoderoso
added a commit
that referenced
this pull request
Jul 24, 2024
* Refs #21230: Migrate Discovery Server CI to Github Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Add RELEASE_SUPPORT.md file Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Add missing flaxy test arg Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Introduce improvements from similar PR reviews Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Apply rev suggestions Signed-off-by: JesusPoderoso <[email protected]> * Refs #21230: Add missing CI checks in PR template Signed-off-by: JesusPoderoso <[email protected]> --------- Signed-off-by: JesusPoderoso <[email protected]> (cherry picked from commit c323886) Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the GitHub CI of this repo, to make it as similar as the one in Fast DDS
Note: While backporting this PR, please ensure the following changes:
ubuntu-ci.yml
file with the proper fallback tagfastdds.repos
tofastrtps.repos
ubuntu-20.04
@Mergifyio backport 1.2.x
Contributor Checklist
Reviewer Checklist
This is an automatic backport of pull request #90 done by [Mergify](https://mergify.com).