Use assign for deserialize instead of temporary std::string

Signed-off-by: Samuel Hyyppä <[email protected]>
eProsima · Oct 10, 2024 · 814913c · 814913c
1 parent 2f90c7b
commit 814913c
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/include/fastcdr/Cdr.h b/include/fastcdr/Cdr.h
@@ -1804,7 +1804,7 @@ class Cdr
     {
         uint32_t length = 0;
         const char* str = read_string(length);
-        value = std::string(str, length);
+        value.assign(str, length);
         return *this;
     }
 

diff --git a/include/fastcdr/FastCdr.h b/include/fastcdr/FastCdr.h
@@ -1541,7 +1541,7 @@ class Cdr_DllAPI FastCdr
     {
         uint32_t length = 0;
         const char* str = read_string(length);
-        string_t = std::string(str, length);
+        string_t.assign(str, length);
         return *this;
     }
 

diff --git a/src/cpp/Cdr.cpp b/src/cpp/Cdr.cpp
@@ -1658,7 +1658,7 @@ Cdr& Cdr::deserialize(
 const char* Cdr::read_string(
         uint32_t& length)
 {
-    const char* ret_value = "";
+    const char* ret_value = nullptr;
     state state_before_error(*this);
 
     *this >> length;

diff --git a/src/cpp/FastCdr.cpp b/src/cpp/FastCdr.cpp
@@ -452,7 +452,7 @@ FastCdr& FastCdr::deserialize(
 const char* FastCdr::read_string(
         uint32_t& length)
 {
-    const char* ret_value = "";
+    const char* ret_value = nullptr;
     state state_before_error(*this);
 
     *this >> length;