[21286] Improve CI workflows in master #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusPoderoso
force-pushed
the
feature/21286
branch
from
083b64b
to
4e83235
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
JesusPoderoso
force-pushed
the
feature/21286
branch
from
dcdaf87
to
c908406
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
|
Build status:
|
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
JesusPoderoso
force-pushed
the
feature/21286
branch
from
f21062c
to
8901c9b
Compare
EduPonz
suggested changes
Jul 9, 2024
| shell: bash | ||
|
|
||
| jobs: | ||
| reusable-ubuntu-ci: |
There was a problem hiding this comment.
Suggested change
| reusable-ubuntu-ci: | |
| fastcdr_test: |
Comment on lines
75
to
78
| - name: Sync eProsima/Fast-CDR repository | ||
| uses: eProsima/eProsima-CI/external/checkout@v0 | ||
| with: | ||
| path: src/fastcdr |
There was a problem hiding this comment.
Suggested change
| - name: Sync eProsima/Fast-CDR repository | |
| uses: eProsima/eProsima-CI/external/checkout@v0 | |
| with: | |
| path: src/fastcdr |
Comment on lines
143
to
151
| - name: Fast CDR Test Report | ||
| uses: eProsima/eProsima-CI/external/test-reporter@v0 | ||
| if: ${{ !cancelled() && inputs.run-tests == true}} | ||
| with: | ||
| name: "Report: ${{ inputs.label }}" | ||
| path: "${{ steps.test_fastcdr.outputs.ctest_results_path }}*.xml" | ||
| working-directory: 'src/fastcdr' | ||
| path-replace-backslashes: 'true' | ||
| list-tests: 'failed' |
There was a problem hiding this comment.
Suggested change
| - name: Fast CDR Test Report | |
| uses: eProsima/eProsima-CI/external/test-reporter@v0 | |
| if: ${{ !cancelled() && inputs.run-tests == true}} | |
| with: | |
| name: "Report: ${{ inputs.label }}" | |
| path: "${{ steps.test_fastcdr.outputs.ctest_results_path }}*.xml" | |
| working-directory: 'src/fastcdr' | |
| path-replace-backslashes: 'true' | |
| list-tests: 'failed' |
| uses: eProsima/eProsima-CI/multiplatform/colcon_test@v0 | ||
| with: | ||
| colcon_meta_file: ${{ github.workspace }}/src/fastcdr/.github/workflows/config/build.meta ${{ github.workspace }}/src/fastcdr/.github/workflows/config/test.meta | ||
| colcon_test_args_default: --event-handlers=console_direct+ --return-code-on-test-failure |
There was a problem hiding this comment.
Suggested change
| colcon_test_args_default: --event-handlers=console_direct+ --return-code-on-test-failure | |
| colcon_test_args_default: --event-handlers=console_direct+ |
There was a problem hiding this comment.
I think we can make do with only one "multiplatform" reusable. The only thing missing is the toolset, but I think we could have it as an opt-in arg that only takes effect on windows
RELEASE_SUPPORT.md
Outdated
| # Release support | ||
|
|
||
|
|
||
| Please, refer to the [main branch](https://github.com/eProsima/Fast-CDR/blob/master/RELEASE_SUPPORT.md) for the latest version of this document. |
There was a problem hiding this comment.
Suggested change
| Please, refer to the [main branch](https://github.com/eProsima/Fast-CDR/blob/master/RELEASE_SUPPORT.md) for the latest version of this document. | |
| Please, refer to the [master branch](https://github.com/eProsima/Fast-CDR/blob/master/RELEASE_SUPPORT.md) for the latest version of this document. |
RELEASE_SUPPORT.md
Outdated
|
|
||
| ## *eProsima Fast DDS* and *Fast CDR* version compatibility | ||
|
|
||
| |Fast DDS Version|Fast DDS Python Version|Fast DDS Python Version branch|Fast DDS Python Latest Release| |
There was a problem hiding this comment.
Suggested change
| |Fast DDS Version|Fast DDS Python Version|Fast DDS Python Version branch|Fast DDS Python Latest Release| | |
| |Fast DDS Version|Fast CDR Version|Fast CDR Version branch|Fast CDR Latest Release| |
|
Build status:
|
|
Build status:
|
Signed-off-by: JesusPoderoso <[email protected]>
JesusPoderoso
force-pushed
the
feature/21286
branch
from
ee9f510
to
c8b7199
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
|
Build status:
|
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
|
Closed in favor of: |
|
Build status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the CI workflows, making them as similar as possible to the Fast DDS workflows.
It also introduces a braching model refactor, similiar as the performed in Fast DDS repository.
It is on top of (and must be merged after) this PR:
Note: While backporting this PR, please ensure the following changes:
ubuntu-ci.yml,mac-ci.ymlandwindows-ci.ymlfiles with the proper fallback branchesubuntu-20.04@Mergifyio backport 2.2.x 2.1.x 1.1.x 1.0.x
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist