Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21825] Fix generated code compilation when a union uses an alias with scope #411

Merged
merged 5 commits into from
Oct 25, 2024
Merged

[21825] Fix generated code compilation when a union uses an alias with scope #411

merged 5 commits into from
Oct 25, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Oct 8, 2024 •
edited by MiguelCompany
Loading

Description

When a union uses an alias with scope, the generated source code fails compiling. This PR fixes it.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware
Refs #21823. Regression test
48efdcd 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #21823. Fix
73b0cda 
Signed-off-by: Ricardo González Moreno <[email protected]>
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 8, 2024
@richiware richiware changed the title Fix generated code compilation when a union uses an alias with scope [21825] Fix generated code compilation when a union uses an alias with scope Oct 8, 2024
@JesusPoderoso JesusPoderoso added this to the v4.1.0 milestone Oct 14, 2024
@richiware richiware mentioned this pull request Oct 16, 2024
Merged
10 tasks
@richiware
Refs #21823. Apply suggestion
009bc8d 
Signed-off-by: Ricardo González Moreno <[email protected]>
@MiguelCompany MiguelCompany self-requested a review October 17, 2024 12:52
MiguelCompany
MiguelCompany previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany modified the milestones: v4.1.0, v4.0.3 Oct 17, 2024
@richiware
Refs #21823. Update submodule
f6b69aa 
Signed-off-by: Ricardo González Moreno <[email protected]>
MiguelCompany
MiguelCompany previously approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@richiware
Refs #21823. Fix render blank lines
ae7ffe5 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware merged commit bbf86e3 into master Oct 25, 2024
4 checks passed
@richiware richiware deleted the bugfix/21823 branch October 25, 2024 06:20
@mergify mergify bot mentioned this pull request Oct 25, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@richiprosima richiprosima Awaiting requested review from richiprosima

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v4.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @MiguelCompany @JesusPoderoso