Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Fast-CDR v2.0.0 [19457] #58

Merged
merged 9 commits into from
Sep 28, 2023
Merged

Support new Fast-CDR v2.0.0 [19457] #58

merged 9 commits into from
Sep 28, 2023

Conversation

richiware
Copy link
Member

No description provided.

@richiware richiware changed the title Support new Fast-CDR v2.0.0 Support new Fast-CDR v2.0.0 [19457] Sep 6, 2023
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The types have not been regenerated after the latest changes introduced in Fast DDS-Gen (in plain fix)

@richiware
Copy link
Member Author

The types have not been regenerated after the latest changes introduced in Fast DDS-Gen (in plain fix)

Done in 3595fe1

JLBuenoLopez
JLBuenoLopez previously approved these changes Sep 20, 2023
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI will probably fail until eProsima/Fast-DDS#3828 is merged. Labeling as CI pending

@JLBuenoLopez JLBuenoLopez added the ci-pending PR which CI is running label Sep 20, 2023
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
JLBuenoLopez
JLBuenoLopez previously approved these changes Sep 27, 2023
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JLBuenoLopez JLBuenoLopez removed the ci-pending PR which CI is running label Sep 27, 2023
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware and others added 3 commits September 27, 2023 13:17
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit bbb019c into main Sep 28, 2023
3 checks passed
@richiware richiware deleted the feature/xcdr branch September 28, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants