Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20017] Fix warning in Mac rewarding unnecessary lambda capture #4052

Merged
merged 1 commit into from
Nov 27, 2023
Merged

[20017] Fix warning in Mac rewarding unnecessary lambda capture #4052

merged 1 commit into from
Nov 27, 2023

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 27, 2023 •
edited by EduPonz
Loading

Description

This PR fixes a warning introduced by #4036.

Backport note: Since #4036 has not yet been backported (to 2.12.x), it would be a nice idea to backport it along with this one.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label Nov 27, 2023
@MiguelCompany MiguelCompany added this to the v2.13.0 milestone Nov 27, 2023
@EduPonz EduPonz added ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Nov 27, 2023
@EduPonz EduPonz merged commit ba4c03b into master Nov 27, 2023
14 checks passed
@EduPonz EduPonz deleted the hotfix/20017 branch November 27, 2023 13:26
MiguelCompany added a commit that referenced this pull request Nov 27, 2023
@MiguelCompany
Fix warning in Mac rewarding unnecessary lambda capture (#4052)
8eae255 
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany mentioned this pull request Nov 27, 2023
Merged
9 tasks
@Mario-DL Mario-DL mentioned this pull request Nov 27, 2023
Merged
12 tasks
MiguelCompany added a commit that referenced this pull request Dec 5, 2023
@MiguelCompany
Improve IgnoreNonExistentSegment test (#4036) (#4057)
5d98cee 
* Improve IgnoreNonExistentSegment test (#4036)

* Refs #19887. Platform specific behavior on IgnoreNonExistentSegment test.

Signed-off-by: Miguel Company <[email protected]>

* Refs #19887. Use `num_threads` in loop.

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>

* Fix warning in Mac rewarding unnecessary lambda capture (#4052)

Signed-off-by: Miguel Company <[email protected]>

---------

Signed-off-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @EduPonz